Skip to content

Deprecate RendererCairo.font{weights,angles} #16285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2020
Merged

Deprecate RendererCairo.font{weights,angles} #16285

merged 1 commit into from
Mar 10, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 21, 2020 •
edited
Loading

They don't really need to be public to start with, and are rendered quite uglyly in the html docs (https://matplotlib.org/devdocs/api/backend_cairo_api.html#matplotlib.backends.backend_cairo.RendererCairo.fontangles) given that we shim cairo using mock (when building the docs).

See Kozea/CairoSVG#259 for the choice of cutoff between NORMAL and BOLD.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Jan 21, 2020
@anntzer
Deprecate RendererCairo.font{weights,angles}
cf2a80d 
They don't really need to be public to start with, and are rendered
quite uglyly in the html docs given that we shim cairo using mock.
@anntzer
Copy link
Contributor Author

anntzer commented Mar 10, 2020

rebased

@timhoffm timhoffm merged commit 8135aad into matplotlib:master Mar 10, 2020
@anntzer anntzer deleted the cairod branch October 31, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
backend: cairo Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm