Skip to content

Simplify Legend.get_children. #16304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2020
Merged

Simplify Legend.get_children. #16304

merged 1 commit into from
Jan 25, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 23, 2020

_legend_box is inited to a non-None value in _init_legend_box which is
called in __init__, so the if self._legend_box check is unnecessary.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Simplify Legend.get_children.
6e04afc 
_legend_box is inited to a non-None value in _init_legend_box which is
called in `__init__`, so the `if self._legend_box` check is unnecessary.
@anntzer anntzer added this to the v3.3.0 milestone Jan 23, 2020
@tacaswell tacaswell merged commit f27a7f3 into matplotlib:master Jan 25, 2020
@anntzer anntzer deleted the legend-children branch January 25, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance topic: legend
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @tacaswell