Make set_x/ymargin() update axes limits, just like margins(). #16340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ed0b3f to
1e491da
Compare
|
What does the change to collections have to do with this? It seems unrelated, or at least unexplained. |
|
It's actually needed because autoscaling triggers in a place where it was previously missing, and exposes a floating point inaccuracy previously present (which was then amplified by the old round-numbers autolimits behavior). |
|
OK, probably would have been clearer in a separate commit, or at least mentioned in the commit message. |
QuLogic
approved these changes
Mar 10, 2020
1e491da to
b5fd761
Compare
|
fair enough, edited the commit message. |
Previously, setting the margins via set_x/ymargin() would not update axes limits, unlike calling margins(). This appears to be a simple oversight. The change in collections.py is necessary because the difference in timing at which autoscale is executed now exposed a floating point inaccuracy (which gets amplified by the old round_numbers autolimits mode).
b5fd761 to
2292f7b
Compare
|
The changes in collections.py were merged separately in #17206. |
efiring
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, setting the margins via set_x/ymargin() would not update
axes limits, unlike calling margins(). This appears to be a simple
oversight.
Closes #7093.
PR Summary
PR Checklist