FIX: catch warnings from pandas in cbook._check_1d #16347

tacaswell · 2020-01-27T19:52:19Z

If we catch the warning or the exception, we need to cast to numpy
because later on in _plot_args we again use multi-dimensional
indexing to up-cast to a 2D array.

closes #16295

PR Summary

PR Checklist

Has Pytest style unit tests
Code is Flake 8 compliant

anntzer · 2020-01-27T21:41:09Z

lib/matplotlib/cbook/__init__.py

+            with warnings.catch_warnings() as w:
+                warnings.filterwarnings("ignore",
+                                        category=DeprecationWarning,
+                                        module='pandas[.*]')


does this mean we're just kicking the can down the road and will need yet another fix when pandas actually change this behavior?

The change will be to raise one of the Exceptions we already catch below so we will still be happy.

fair enough

If we catch the warning or the exception, we need to cast to numpy because later on in `_plot_args` we again use multi-dimensional indexing to up-cast to a 2D array. closes matplotlib#16295

tacaswell · 2020-01-28T16:41:19Z

@bashtage However on older versions we are not getting back a numpy array

In [1]: import pandas as pd                                                                                                                                                                                                                                   

In [2]: d = pd.Series([])                                                                                                                                                                                                                                     

In [3]: d.index[:, None]                                                                                                                                                                                                                                      
Out[3]: Int64Index([], dtype='int64')

In [4]: type(d.index[:, None])                                                                                                                                                                                                                                
Out[4]: pandas.core.indexes.numeric.Int64Index

In [5]: d.index[:, None].ndim                                                                                                                                                                                                                                 
Out[5]: 1

In [6]: pd.__version__                                                                                                                                                                                                                                        
Out[6]: '0.25.1'

story645 · 2020-01-28T16:54:33Z

lib/matplotlib/cbook/__init__.py

            # was an unintentional quirk of pandas the above line will raise
            # an exception in the future.


since the above line is getting deleted, this comment is no longer relevant.

It is still relevant, the line above was moved down and put inside the context manager below.

Ok, then it should be changed to "the line below" or moved to be next to the line it's referring to:

ndim = x[:, None].ndim #will raise exception in future

lib/matplotlib/cbook/__init__.py

lib/matplotlib/tests/test_axes.py

lumberbot-app · 2020-01-28T23:20:52Z

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

Checkout backport branch and update it.

$ git checkout v2.2.x
$ git pull

Cherry pick the first parent branch of the this PR on top of the older branch:

$ git cherry-pick -m1 a7501f94988b952bd97a7b382b86c924cf464f62

You will likely have some merge/cherry-pick conflict here, fix them and commit:

$ git commit -am 'Backport PR #16347: FIX: catch warnings from pandas in cbook._check_1d'

Push to a named branch :

git push YOURFORK v2.2.x:auto-backport-of-pr-16347-on-v2.2.x

Create a PR against branch v2.2.x, I would have named this PR:

"Backport PR #16347 on branch v2.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

lumberbot-app · 2020-01-28T23:21:31Z

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

Checkout backport branch and update it.

$ git checkout v3.1.x
$ git pull

Cherry pick the first parent branch of the this PR on top of the older branch:

$ git cherry-pick -m1 a7501f94988b952bd97a7b382b86c924cf464f62

You will likely have some merge/cherry-pick conflict here, fix them and commit:

$ git commit -am 'Backport PR #16347: FIX: catch warnings from pandas in cbook._check_1d'

Push to a named branch :

git push YOURFORK v3.1.x:auto-backport-of-pr-16347-on-v3.1.x

Create a PR against branch v3.1.x, I would have named this PR:

"Backport PR #16347 on branch v3.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

…k._check_1d

…k._check_1d Merge pull request matplotlib#16347 from tacaswell/fix_pandas_index_deprecation FIX: catch warnings from pandas in cbook._check_1d Conflicts: lib/matplotlib/tests/test_axes.py - new test in middle of section of tests not on v2.2.x yet, only kept new test

…k._check_1d Merge pull request matplotlib#16347 from tacaswell/fix_pandas_index_deprecation FIX: catch warnings from pandas in cbook._check_1d

…347-on-v3.2.x Backport PR #16347 on branch v3.2.x (FIX: catch warnings from pandas in cbook._check_1d)

…-v3.1.x Backport PR #16347: FIX: catch warnings from pandas in cbook._check_1d

…-v2.2.x Backport PR #16347: FIX: catch warnings from pandas in cbook._check_1d

jklymak · 2020-01-30T20:06:04Z

So, test_bar_pandas is still failing, at least w/ #16286 which I rebased, so it should include this fix?

jklymak · 2020-01-30T20:08:35Z

I guess because pandas 1.0 is out?

jklymak · 2020-01-30T20:18:18Z

I actually don't understand. The warning is from pandas 1.0 (old pandas pass this test) and the result is:

E           DeprecationWarning: Support for multi-dimensional indexing (e.g. `index[:, None]`) on an Index is deprecated and will be removed in a future version.  Convert to a numpy array before indexing instead.

So somehow we are no longer capturing the warning.

anntzer reviewed Jan 27, 2020

View reviewed changes

FIX: catch warnings from pandas in cbook._check_1d

c7eddd6

If we catch the warning or the exception, we need to cast to numpy because later on in `_plot_args` we again use multi-dimensional indexing to up-cast to a 2D array. closes matplotlib#16295

tacaswell force-pushed the fix_pandas_index_deprecation branch from ae4354c to c7eddd6 Compare January 27, 2020 23:33

tacaswell added this to the v2.2.5 milestone Jan 27, 2020

tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jan 28, 2020

story645 requested changes Jan 28, 2020

View reviewed changes

tacaswell added 2 commits January 28, 2020 15:39

DOC: clarified comments in code about what this code is doing

676f3eb

TST: renamed test to be less idiomatic

77e7b31

tacaswell requested a review from story645 January 28, 2020 21:07

story645 approved these changes Jan 28, 2020

View reviewed changes

tacaswell mentioned this pull request Jan 28, 2020

Multi-dimensional Index indexing followups pandas-dev/pandas#30867

Closed

jklymak approved these changes Jan 28, 2020

View reviewed changes

jklymak merged commit a7501f9 into matplotlib:master Jan 28, 2020

lumberbot-app bot added the status: needs manual backport label Jan 28, 2020

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 28, 2020

Backport PR matplotlib#16347: FIX: catch warnings from pandas in cboo…

ff8b1a9

…k._check_1d

meeseeksmachine mentioned this pull request Jan 28, 2020

Backport PR #16347 on branch v3.2.x (FIX: catch warnings from pandas in cbook._check_1d) #16360

Merged

tacaswell deleted the fix_pandas_index_deprecation branch January 28, 2020 23:22

This was referenced Jan 28, 2020

Backport PR #16347: FIX: catch warnings from pandas in cbook._check_1d #16361

Merged

Backport PR #16347: FIX: catch warnings from pandas in cbook._check_1d #16362

Merged

tacaswell added a commit that referenced this pull request Jan 29, 2020

Merge pull request #16360 from meeseeksmachine/auto-backport-of-pr-16…

89ff308

…347-on-v3.2.x Backport PR #16347 on branch v3.2.x (FIX: catch warnings from pandas in cbook._check_1d)

timhoffm added a commit that referenced this pull request Jan 29, 2020

Merge pull request #16362 from tacaswell/auto-backport-of-pr-16347-on…

bbf4c7c

…-v3.1.x Backport PR #16347: FIX: catch warnings from pandas in cbook._check_1d

timhoffm added a commit that referenced this pull request Jan 29, 2020

Merge pull request #16361 from tacaswell/auto-backport-of-pr-16347-on…

d0cdf97

…-v2.2.x Backport PR #16347: FIX: catch warnings from pandas in cbook._check_1d

jklymak mentioned this pull request Jan 30, 2020

pyplot.plot using pandas series raises DeprecationWarning with pandas=1.0.0rc0 #16295

Closed

timhoffm removed the status: needs manual backport label Feb 1, 2020

tacaswell mentioned this pull request Feb 3, 2020

review how we duck-type non-numpy inputs #16402

Open

jklymak mentioned this pull request Jan 6, 2022

FIX: stop supporting strange pandas #22128

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FIX: catch warnings from pandas in cbook._check_1d #16347

FIX: catch warnings from pandas in cbook._check_1d #16347

tacaswell commented Jan 27, 2020 •

edited

Loading

anntzer Jan 27, 2020

tacaswell Jan 27, 2020

anntzer Jan 27, 2020

tacaswell commented Jan 28, 2020

story645 Jan 28, 2020

tacaswell Jan 28, 2020

story645 Jan 28, 2020 •

edited

Loading

lumberbot-app bot commented Jan 28, 2020

lumberbot-app bot commented Jan 28, 2020

jklymak commented Jan 30, 2020

jklymak commented Jan 30, 2020

jklymak commented Jan 30, 2020

		# was an unintentional quirk of pandas the above line will raise
		# an exception in the future.

FIX: catch warnings from pandas in cbook._check_1d #16347

FIX: catch warnings from pandas in cbook._check_1d #16347

Conversation

tacaswell commented Jan 27, 2020 • edited Loading

PR Summary

PR Checklist

anntzer Jan 27, 2020

Choose a reason for hiding this comment

tacaswell Jan 27, 2020

Choose a reason for hiding this comment

anntzer Jan 27, 2020

Choose a reason for hiding this comment

tacaswell commented Jan 28, 2020

story645 Jan 28, 2020

Choose a reason for hiding this comment

tacaswell Jan 28, 2020

Choose a reason for hiding this comment

story645 Jan 28, 2020 • edited Loading

Choose a reason for hiding this comment

lumberbot-app bot commented Jan 28, 2020

lumberbot-app bot commented Jan 28, 2020

jklymak commented Jan 30, 2020

jklymak commented Jan 30, 2020

jklymak commented Jan 30, 2020

tacaswell commented Jan 27, 2020 •

edited

Loading

story645 Jan 28, 2020 •

edited

Loading