Skip to content

Group all init of Legend.legendPatch together. #16351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2020
Merged

Group all init of Legend.legendPatch together. #16351

merged 1 commit into from
Mar 10, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 27, 2020

Seems easier to follow that spreading the init of legendPatch across
__init__ and intertwined with other things.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Jan 27, 2020
timhoffm
timhoffm approved these changes Jan 28, 2020
View reviewed changes
@QuLogic
Copy link
Member

QuLogic commented Mar 10, 2020

Seems to have broken: rcParams is undefined.

@anntzer
Group all init of Legend.legendPatch together.
e6c3c5d 
Seems easier to follow that spreading the init of legendPatch across
`__init__` and intertwined with other things.
@anntzer
Copy link
Contributor Author

anntzer commented Mar 10, 2020

ah, prs crossing one another... another try.

tacaswell
tacaswell approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone can merge on CI green.

@QuLogic QuLogic merged commit ffe6c78 into matplotlib:master Mar 10, 2020
@anntzer anntzer deleted the shortlegend branch March 10, 2020 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance topic: legend
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @QuLogic @tacaswell @timhoffm