Skip to content

Pin docutils #16358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Pin docutils #16358

merged 1 commit into from
Jan 28, 2020

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Jan 28, 2020

PR Summary

We have pinned sphinx<2 on the 2.2.x branch. As a follow-up we also have to pin docutils<0.16.

Docutils 0.16 introduced FutureWarnings on node list access:

/home/circleci/.local/lib/python3.5/site-packages/sphinx/util/nodes.py:94: FutureWarning: 
   The iterable returned by Node.traverse()
   will become an iterator instead of a list in Docutils > 0.16.

https://sourceforge.net/p/docutils/mailman/message/36765733/

Code that circumvents these warnings was only introduced in sphinx 2.3 (sphinx-doc/sphinx#6887).

We have two options:

  • either limit docutils to <0.16
  • or pull sphinx for this branch up (which probably needs additional backports, because we had a reason to pin sphinx.

The former seems far easier and is thus what this PR does.

This is required to get 2.2.x docs build and in particular the prerequisite for #16352.

@timhoffm timhoffm added this to the v2.2.5 milestone Jan 28, 2020
@tacaswell
Copy link
Member

I could have sworn I dealt with this someplace else recently...

Will have to make sure we are careful on the branch merge up to not pull this forward.

@tacaswell tacaswell merged commit 80c2280 into matplotlib:v2.2.x Jan 28, 2020
@timhoffm timhoffm deleted the pin-docutils branch January 29, 2020 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants