Fix usetex_baseline_test. #16373
Merged
Fix usetex_baseline_test. #16373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16373 +/- ##
==========================================
- Coverage 80.85% 80.45% -0.41%
==========================================
Files 307 307
Lines 75745 74403 -1342
Branches 9690 9686 -4
==========================================
- Hits 61245 59859 -1386
- Misses 11961 11996 +35
- Partials 2539 2548 +9
Continue to review full report at Codecov.
|
|
You must be on codecov’s naughty list ;-) |
6 tasks
tacaswell
approved these changes
Feb 10, 2020
|
@tacaswell good to go? I have a followup PR which actually fixes the baseline problem in all cases :p |
timhoffm
reviewed
Feb 11, 2020
| class Axes(maxes.Axes): | ||
|
|
||
| @maxes.subplot_class_factory | ||
| class Subplot(maxes.Axes): |
There was a problem hiding this comment.
Maybe use another name like LatexSubplot or similar to make it more explicit that this is something special and not to be confused with our regular subplot semantics.
The previous version didn't actually compare usetex=False and usetex=True because usetex state is stored in the text instance, so fix that. (The custom axes subclass remains necessary to compare text.latex.preview=False and =True.) Also misc. cleanups.
edd2237 to
9fa950c
Compare
timhoffm
approved these changes
Feb 11, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version didn't actually compare usetex=False and
usetex=True because usetex state is stored in the text instance, so fix
that. (The custom axes subclass remains necessary to compare
text.latex.preview=False and =True.)
Also misc. cleanups.
old:
new:
PR Summary
PR Checklist