Skip to content

FIX: catch on message content, not module #16379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2020
Merged

FIX: catch on message content, not module #16379

merged 1 commit into from
Jan 31, 2020

Conversation

tacaswell
Copy link
Member

Not all of the warnings from pandas report that they are from pandas.

Closes #16295 (again)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell
FIX: catch on message content, not module
b53b588 
Not all of the warnings from pandas report that they are from pandas.

Closes matplotlib#16295 (again)
@tacaswell tacaswell requested a review from jklymak January 31, 2020 02:39
@tacaswell tacaswell added this to the v2.2.5 milestone Jan 31, 2020
@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jan 31, 2020
@tacaswell
Copy link
Member Author

Given that this is un-breaking CI I propose that this can be merged by 1 person (other than me) when (if 🤞 ) CI passes.

@story645 story645 merged commit c45beef into matplotlib:master Jan 31, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 31, 2020
@story645 @meeseeksmachine
Backport PR matplotlib#16379: FIX: catch on message content, not module
1652994
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 31, 2020
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 31, 2020
@story645 @meeseeksmachine
Backport PR matplotlib#16379: FIX: catch on message content, not module
85e3f1c
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 31, 2020
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 31, 2020
@story645 @meeseeksmachine
Backport PR matplotlib#16379: FIX: catch on message content, not module
bc3b605
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 31, 2020
Merged
@tacaswell tacaswell deleted the fix_pandas_warning_catch branch January 31, 2020 05:43
@jklymak
Copy link
Member

jklymak commented Jan 31, 2020

Thanks @tacaswell!

jklymak added a commit that referenced this pull request Jan 31, 2020
@jklymak
Merge pull request #16383 from meeseeksmachine/auto-backport-of-pr-16…
8e72280 
…379-on-v3.2.x

Backport PR #16379 on branch v3.2.x (FIX: catch on message content, not module)
jklymak added a commit that referenced this pull request Jan 31, 2020
@jklymak
Merge pull request #16381 from meeseeksmachine/auto-backport-of-pr-16…
6f0a313 
…379-on-v2.2.x

Backport PR #16379 on branch v2.2.x (FIX: catch on message content, not module)
tacaswell added a commit that referenced this pull request Jan 31, 2020
@tacaswell
Merge pull request #16382 from meeseeksmachine/auto-backport-of-pr-16…
55894c2 
…379-on-v3.1.x

Backport PR #16379 on branch v3.1.x (FIX: catch on message content, not module)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@story645 story645 story645 approved these changes

@jklymak jklymak Awaiting requested review from jklymak

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v2.2.5
Development

Successfully merging this pull request may close these issues.

pyplot.plot using pandas series raises DeprecationWarning with pandas=1.0.0rc0
3 participants
@tacaswell @jklymak @story645