Skip to content

Slightly improve streamplot code legibility. #16423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2020
Merged

Slightly improve streamplot code legibility. #16423

merged 1 commit into from
Feb 6, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 6, 2020

__getitem__ is never called with more than a single arg, and we can
just use normal indexing on _mask both for getting and for setting.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Slightly improve streamplot code legibility.
1820339 
`__getitem__` is never called with more than a single arg, and we can
just use normal indexing on _mask both for getting and for setting.
@anntzer anntzer added this to the v3.3.0 milestone Feb 6, 2020
@dstansby dstansby merged commit bd02c9d into matplotlib:master Feb 6, 2020
@anntzer anntzer deleted the streamplot branch February 6, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @dstansby