MNT: rename internal variable #16425
Merged
+10
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Feb 6, 2020
49b95c4 to
6d99af6
Compare
jklymak
approved these changes
Feb 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #16425 +/- ##
==========================================
- Coverage 80.85% 80.54% -0.31%
==========================================
Files 307 307
Lines 75745 74407 -1338
Branches 9690 9688 -2
==========================================
- Hits 61245 59933 -1312
+ Misses 11961 11934 -27
- Partials 2539 2540 +1
Continue to review full report at Codecov.
|
When I wrote this code ~4.5 years ago I was a bit cranky and used a very sarcastic variable name (snowflake) to handle a class of special cases when parsing math text. It has recently come to light that this name can make it into user visible error messages. This renames the variable to a less sarcastic and more descriptive variable name (it handles the case of symbols who's names start with a valid accent; we should parse it as the symbol, not an accent on the rest of the symbol name).
6d99af6 to
9a7ddd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
When I wrote this code ~4.5 years ago I was a bit cranky and used a
very sarcastic variable name (snowflake) to handle a class of special
cases when parsing math text. It has recently come to light that this
name can make it into user visible error messages. This renames the
variable to a less sarcastic and more descriptive variable name (it
handles the case of symbols who's names start with a valid accent; we
should parse it as the symbol, not an accent on the rest of the symbol
name).
PR Checklist