Skip to content

Fix mplot3d projection #16472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 11, 2020
Merged

Conversation

eric-wieser
Copy link
Contributor

Redo of gh-8896, which was force-pushed out of the history.

There is now only a single commit with image updates.

It is likely that the images are wrong, because my machine does not produce CI-compatible images.

eric-wieser and others added 4 commits February 11, 2020 16:17
Fixes matplotlibgh-8894, by always using a "position" that maintains a uniform coordinate system.

Test added - when viewed from above, the plot should be square not rhombic.
…ously

This sets it to have a 4:3 aspect ratio, which matches what would result from a typical figure layout
As requested in review feedback - since all the images changed, may as well
restyle them.

Note that this restyling caused a test to become platform-dependent on the
anti-aliasing on the edges of a narrow line - presumably due to the resolution
decrease making the line narrower - so a non-zero `tol` value was added.
@eric-wieser eric-wieser requested a review from anntzer February 11, 2020 16:27
@eric-wieser eric-wieser force-pushed the fix-mplot3d-projection branch from 8ffc57b to ce08435 Compare February 11, 2020 16:51
@jklymak jklymak added this to the v3.3.0 milestone Feb 11, 2020
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be passing!

@anntzer
Copy link
Contributor

anntzer commented Feb 11, 2020

I'll wait for travis to pass too.

@anntzer
Copy link
Contributor

anntzer commented Feb 11, 2020

travis failure is spurious.

@anntzer anntzer merged commit 4746a8d into matplotlib:master Feb 11, 2020
tacaswell added a commit to tacaswell/matplotlib that referenced this pull request May 27, 2020
To make bbox_inches='tight' work correctly, we cache the positions of
all of the axes, change their aspect to 'auto', adjust the transforms
on the figure, render the output, and then restore the previous
setting of aspect to each of the figures.  This prevent the Axes from
trying to adjust their size on draw. This matters because for the
render that is emitted the figure transforms are out of sync with the
figure size.

As part of cleaning fixing the rendering of Axes3D in matplotlib#8896 / matplotlib#16472
we started to use apply_aspect to re-size the area the Axes3D takes up
to maintain a fixed ratio between the axes when the aspect is "auto".
However this conflicts with the expectation in tight_bbox.adjust_bbox
as it assumes setting the aspect to "auto" will prevent any axes
resizing.

This commit addresses this by:
 - exiting the Axes3D.apply_aspect early if aspect is auto
 - adding a new aspect mode 'auto_pb' which is the default
   for Axes3D which maintains the current master branch behavior
   of maintaining a fixed ratio between the sizes of the x, y z axis
   independent of the data limits.
 - re implement several functions on Axes3D to make sure they handle
   sharez correctly.

closes matplotlib#16463.
tacaswell added a commit to tacaswell/matplotlib that referenced this pull request May 30, 2020
The way that bbox_inches='tight' is implemented we need to ensure that
we do not try to adjust the aspect during the draw (because we have
temporarily de-coupled the reported figure size from the transforms
which results in the being distorted).  Previously we did not have a
way to fix the aspect ratio in screen space of the Axes (only the
aspect ratio in dataspace) however in 3.3 we gained this ability for
both Axes (matplotlib#14917) and Axes3D (matplotlib#8896 / matplotlib#16472).

Rather than add an aspect value to `set_aspect` to handle this case,
in the tight_bbox code we monkey-patch the `apply_aspect` method with
a no-op function and then restore it when we are done.  Previously we
would set the aspect to "auto" and restore it in the same places.

closes matplotlib#16463.
tacaswell added a commit to tacaswell/matplotlib that referenced this pull request Jun 4, 2020
The way that bbox_inches='tight' is implemented we need to ensure that
we do not try to adjust the aspect during the draw (because we have
temporarily de-coupled the reported figure size from the transforms
which results in the being distorted).  Previously we did not have a
way to fix the aspect ratio in screen space of the Axes (only the
aspect ratio in dataspace) however in 3.3 we gained this ability for
both Axes (matplotlib#14917) and Axes3D (matplotlib#8896 / matplotlib#16472).

Rather than add an aspect value to `set_aspect` to handle this case,
in the tight_bbox code we monkey-patch the `apply_aspect` method with
a no-op function and then restore it when we are done.  Previously we
would set the aspect to "auto" and restore it in the same places.

closes matplotlib#16463.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants