Skip to content

Switch default of stem(use_line_collection=...) to True. #16474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 11, 2020

... as announced for mpl3.3.

We could consider deprecating use_line_collection later (as it's
basically an artefact of the transition), though there's no real hurry
for it.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Feb 11, 2020
@dstansby
Copy link
Member

🎉 glad to see this come to fruition!

Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional on CI.

It may be worth adding a comment to the source code indicating that we may want to deprecate that parameter in the future.

... as announced for mpl3.3.

We could consider deprecating use_line_collection later (as it's
basically an artefact of the transition), though there's no real hurry
for it.
@anntzer
Copy link
Contributor Author

anntzer commented Feb 11, 2020

done (in the docs, no reason to hide this from the users)

@dstansby dstansby merged commit 85a96fb into matplotlib:master Feb 12, 2020
@anntzer anntzer deleted the ulc branch February 12, 2020 11:07
dstansby added a commit to dstansby/matplotlib that referenced this pull request Feb 12, 2020
Switch default of stem(use_line_collection=...) to True.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants