Use vlines() and plot(), not stem(), in timeline example. #16475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Feb 11, 2020
| # distinguish even close-by events. In contrast to a usual stem plot, we will | ||
| # shift the markers to the baseline for visual emphasis on the one-dimensional | ||
| # nature of the time line. | ||
| # Next, we'll create a stem plot with some variation in levels as to |
There was a problem hiding this comment.
I wouldn't call it "stem plot" then.
There was a problem hiding this comment.
I know, but I couldn't really think of a better name...
There was a problem hiding this comment.
IMHO the whole section could be rewritten to better descibe the intention and how we use the matplotlib functions to achieve that. But let's not make perfect the enemy of the good.
timhoffm
approved these changes
Feb 11, 2020
| # distinguish even close-by events. In contrast to a usual stem plot, we will | ||
| # shift the markers to the baseline for visual emphasis on the one-dimensional | ||
| # nature of the time line. | ||
| # Next, we'll create a stem plot with some variation in levels as to |
There was a problem hiding this comment.
IMHO the whole section could be rewritten to better descibe the intention and how we use the matplotlib functions to achieve that. But let's not make perfect the enemy of the good.
It's actually easier (IMO...) to achieve the desired result by combining vlines() and plot() is actually much easier rather than by using stem() and then fiddling with the artists. (The visual result is unchanged.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's actually easier (IMO...) to achieve the desired result by
combining vlines() and plot() is actually much easier rather than by
using stem() and then fiddling with the artists.
(The visual result is unchanged.)
PR Summary
PR Checklist