Skip to content

Document default value of save_count parameter in FuncAnimation #16532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2020
Merged

Document default value of save_count parameter in FuncAnimation #16532

merged 1 commit into from
Feb 17, 2020

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Feb 16, 2020 •
edited
Loading

PR Summary

Reduces the confusion of #8278 (in particular #8278 (comment) and #8278 (comment)) by documenting the current behavior.

@timhoffm timhoffm added this to the v3.2.0 milestone Feb 16, 2020
@tacaswell tacaswell merged commit 2bf4392 into matplotlib:master Feb 17, 2020
@lumberbot-app
Copy link

lumberbot-app bot commented Feb 17, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 2bf43924a4b3191684193beee4f360e90ed503d0
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #16532: Document default value of save_count parameter in FuncAnimation'
  1. Push to a named branch :
git push YOURFORK v3.2.x:auto-backport-of-pr-16532-on-v3.2.x
  1. Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR #16532 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

tacaswell added a commit to tacaswell/matplotlib that referenced this pull request Feb 17, 2020
@tacaswell
Backport PR matplotlib#16532: Document default value of save_count pa…
02f32f0 
…rameter in FuncAnimation

Merge pull request matplotlib#16532 from timhoffm/doc-save_count

DOC: Document default value of save_count parameter in FuncAnimation
Conflicts:
	lib/matplotlib/animation.py
          - collision with removing "optional" from docstrings
@tacaswell tacaswell mentioned this pull request Feb 17, 2020
Merged
6 tasks
@timhoffm timhoffm deleted the doc-save_count branch February 17, 2020 02:42
dstansby added a commit that referenced this pull request Feb 17, 2020
@dstansby
Merge pull request #16543 from tacaswell/auto-backport-of-pr-16532-on…
26e5801 
…-v3.2.x

Backport PR #16532: Document default value of save_count parameter in…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
Documentation topic: animation
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@timhoffm @tacaswell