API/TST: minimum versions #16536
Merged
API/TST: minimum versions #16536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents an inconsistent test environment because packaging 20.1 requires pyparsing >=2.0.2 Picked 2.0.3 as the change log noted that 2.0.3 fixes a major regression from 2.0.2.
When we set this up py36 was the newest (not the oldest) python we supported.
Should have been removed in 695e729
Kojoley
approved these changes
Feb 18, 2020
timhoffm
reviewed
Feb 19, 2020
| @@ -1,15 +1,10 @@ | |||
| # pip requirements for all the travis builds | |||
|
|
|||
| coverage | |||
| cycler | |||
| numpy | |||
There was a problem hiding this comment.
Why don't we need these anymore?
There was a problem hiding this comment.
They are matplotlib dependencies and will be installed anyway, the same change was proposed by @anntzer #16117 (comment)
There was a problem hiding this comment.
Correct, we should only specify these if we want to actively pin the back to an old version.
dstansby
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16116
This: