Delay checking for existence of postscript distillers. #16537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20ceb89 to
cab5463
Compare
tacaswell
reviewed
Feb 16, 2020
| @@ -1239,6 +1250,9 @@ def xpdf_distill(tmpfile, eps=False, ptype='letter', bbox=None, rotated=False): | |||
| operators. This distiller is preferred, generating high-level postscript | |||
| output that treats text as text. | |||
| """ | |||
| mpl._get_executable_info("gs") | |||
There was a problem hiding this comment.
Should this check be up around line 1218?
There was a problem hiding this comment.
No, this is for ps2pdf (which is actually just a thin wrapper script around gs). Added a comment clarifying.
There was a problem hiding this comment.
Why doesn't gs_distill need an equivalent check?
There was a problem hiding this comment.
It already calls mpl._get_executable_info("gs") basically at the beginning.
There was a problem hiding this comment.
Sorry, I was looking for it on it's own line an not parsing that it was called in-line to another function call 🐑
cab5463 to
158f6e0
Compare
Currently, if one has `ps.usedistiller` set in their matplotlibrc, matplotlib will immediately check for the presence of ghostscript (and possibly pstopdf) at import time and run them in subprocesses to check their version, even though they may not be needed at all (if the user is not going to save a postscript image); this can quite slow down import time. Compare e.g. with `text.usetex` which requires the presence of a `tex` install, but doesn't check for its presence until it is actually needed. Delay the checking for the presence of the distillers until we actually need them. For consistency with the old behavior, don't error out if they are missing, but just emit a warning.
158f6e0 to
926c347
Compare
tacaswell
approved these changes
Feb 18, 2020
QuLogic
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if one has
ps.usedistillerset in their matplotlibrc,matplotlib will immediately check for the presence of ghostscript (and
possibly pstopdf) at import time and run them in subprocesses to check
their version, even though they may not be needed at all (if the user is
not going to save a postscript image); this can quite slow down import
time. Compare e.g. with
text.usetexwhich requires the presence ofa
texinstall, but doesn't check for its presence until it is actuallyneeded.
Delay the checking for the presence of the distillers until we actually
need them. For consistency with the old behavior, don't error out if
they are missing, but just emit a warning.
PR Summary
PR Checklist