Skip to content

Update custom boxstyles example. #16615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2020
Merged

Update custom boxstyles example. #16615

merged 1 commit into from
Mar 1, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 1, 2020

  • Merge the two examples together (especially given that one of them
    demonstrates private API anyways...).
  • General modernization/simplification/s-g-ification.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Mar 1, 2020
timhoffm
timhoffm approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo minor formatting

@anntzer
Update custom boxstyles example.
8db6d05 
- Merge the two examples together (especially given that one of them
  demonstrates private API anyways...).
- General modernization/simplification/s-g-ification.
@timhoffm timhoffm merged commit ed79353 into matplotlib:master Mar 1, 2020
@anntzer anntzer deleted the boxstyles branch March 2, 2020 00:03
@QuLogic QuLogic mentioned this pull request Jun 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anntzer @timhoffm