Skip to content

Deprecate autofmt_xdate(which=None) to mean which="major". #16636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2020
Merged

Deprecate autofmt_xdate(which=None) to mean which="major". #16636

merged 1 commit into from
Mar 11, 2020
+21 −9

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 2, 2020

This makes the docstring and signature simpler, and explicitly passing
which=None to mean which="major" just seems wicked...

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Mar 2, 2020
@anntzer
Deprecate autofmt_xdate(which=None) to mean which="major".
e53eedb 
This makes the docstring and signature simpler, and explicitly passing
which=None to mean which="major" just seems wicked...
@anntzer
Copy link
Contributor Author

anntzer commented Mar 10, 2020

rebased

@anntzer anntzer force-pushed the autofmtxdate_major branch from d5795c9 to e53eedb Compare March 10, 2020 23:59
@QuLogic
Copy link
Member

QuLogic commented Mar 11, 2020

Test failure is due to #16693, and I can't restart.

@QuLogic QuLogic merged commit 50242cf into matplotlib:master Mar 11, 2020
@anntzer anntzer deleted the autofmtxdate_major branch March 11, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm