Document filling of Poly3DCollection #16648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9f3ac12 to
af1eb5c
Compare
eric-wieser
reviewed
Mar 4, 2020
| The calculation method for the z-order. | ||
| See `~.Poly3DCollection.set_zsort` for details. | ||
| *args, **kwargs | ||
| All other parameters are forwarded to `.PolyCollection`. |
There was a problem hiding this comment.
What does . mean at the beginning of a reference? Is this a sphinx thing, or something specific to matplotlib?
There was a problem hiding this comment.
It's a "sphinx thing". But there is documentation on it in the matplotlib dev guide: https://matplotlib.org/devdocs/devel/documenting_mpl.html#referring-to-other-code
There was a problem hiding this comment.
anntzer
approved these changes
Mar 11, 2020
| to an incorrect visualization of the 3D area. | ||
|
|
||
| If you need filled areas, it is recommended to create them via | ||
| `~mpl_toolkits.mplot3d.axes3d.Axes3D.plot_trisurf`, which creates a |
There was a problem hiding this comment.
I would just write .Axes3D.plot_trisurf (or ~.Axes3D.plot_trisurf).
Can self-merge with or without that change.
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 13, 2020
QuLogic
added a commit
that referenced
this pull request
Mar 14, 2020
…648-on-v3.2.x Backport PR #16648 on branch v3.2.x (Document filling of Poly3DCollection)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #16633, by documenting the limitations and linking to
plot_trisurfas a better way to create filled surfaces.