-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Make format_coord messagebox resize with the window and the content in osx backend #16710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an OSX programmer, but from the outside this looks reasonable. Maybe someone with OSX can test this?
The only issue here is that the height over runs the toolbar if the window is very narrow |
Thx. It occurred when the width of the toolbar is too small to hold the text. I have fixed this by limiting the maximum number of lines to 2. Now it shows perfectly at any width. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also not an OSX programer, but the proof is in the pudding that this works.
Seems to be enough approvals to merge. Thanks @yuezhihan! |
Been waiting for this for over 2 years - thank you! (re: #10375) |
PR Summary
closes #16498
Example:
Before:


After:



PR Checklist