Deprecate rcParams["datapath"] in favor of mpl.get_data_path(). #16722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rcParam cannot be meaningfully set by the end user from their matplotlibrc or Python code. (This is a manual backport to 3.2.x.)
6 tasks
|
@tacaswell I don't think this will help if the user directly assigns to rcParams["datapath"]? |
|
It will not, but I thought the OP was loading it from a file? The other option is to add a flag to suppress checking the rcParams so it works no matter what. |
|
OK, I guess your solution works for that case... |
QuLogic
reviewed
Mar 16, 2020
Closes matplotlib#16678 This does a bit of jiggery-pokery to respect the datapath set in the users matplotlibrc. This is going to have an expedited deprecation cycle as we don't think end-users should be setting this rcparam.
5f62526 to
ecd95c4
Compare
QuLogic
approved these changes
Mar 16, 2020
Co-Authored-By: Elliott Sales de Andrade <quantum.analyst@gmail.com>
|
So this fixes the thing we broke for the OP but does not fully restore the functionality. I am 👍 on this being good enough, but open to the argument we should fully restore the rcparam functionality. |
|
@tacaswell's patch looks fine to me. |
tacaswell
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rcParam cannot be meaningfully set by the end user from their
matplotlibrc or Python code.
(This is a manual backport to 3.2.x of #16417; see discussion there.)
PR Summary
PR Checklist