Skip to content

Fix pgf+bbox_inches=tight combo #16732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix pgf+bbox_inches=tight combo #16732

wants to merge 3 commits into from

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 11, 2020

PR Summary

Revert #14134 and its followup #14216, and add a test, to fix #16731.
This is only for 3.2.x; a better fix for master will come separately.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. backend: pgf labels Mar 11, 2020
@anntzer anntzer added this to the v3.2.1 milestone Mar 11, 2020
@anntzer anntzer mentioned this pull request Mar 11, 2020
Closed
@tacaswell
Copy link
Member

Travis failure was brew timing out, restarting.

@anntzer anntzer mentioned this pull request Mar 11, 2020
Merged
6 tasks
@anntzer
Copy link
Contributor Author

anntzer commented Mar 11, 2020

Actually perhaps #16734 is a better solution (that can go both to 3.2.x and to master).

tacaswell
tacaswell requested changes Mar 13, 2020
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting in a change request to block merging in favor of #16734

@QuLogic QuLogic mentioned this pull request Mar 13, 2020
Open
@tacaswell
Copy link
Member

Closing as #16734 has been merged.

@tacaswell tacaswell closed this Mar 14, 2020
@anntzer anntzer deleted the dryrun branch March 14, 2020 11:44
@QuLogic QuLogic removed this from the v3.2.1 milestone Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell requested changes

Assignees
No one assigned
Labels
backend: pgf Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @tacaswell @QuLogic