Simplify interactive zoom handling. #16757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are private. Let‘s go the other way round, stay PEP8 conform, and maybe later rename |
- During interactive zoom, one can additionally press x or y to restrict zooming to the x or y direction. Instead of adding separate key_press_handlers to check that and maintaining that state in `_zoom_mode`, one can simply read `event.key` in the mouse handler (because the key needs to stay pressed for this to be active -- there's no behavior change). - The `ids_zoom` list of callback ids can then be replaced by a single `_id_zoom`. - When stashing info in `_xypress` to perform the zoom, one only needs to know where the zoom started (x, y) and the underlying axes (a). The index (i) and view (a._get_view()) are unused, so just remove them.
|
ok, did that, and also replaced _idDrag by _id_drag in a separate commit. |
QuLogic
approved these changes
Mar 14, 2020
timhoffm
approved these changes
Mar 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zooming to the x or y direction. Instead of adding separate
key_press_handlers to check that and maintaining that state in
_zoom_mode, one can simply readevent.keyin the mouse handler(because the key needs to stay pressed for this to be active --
there's no behavior change).
ids_zoomlist of callback ids can then be replaced by a single_id_zoom._xypressto perform the zoom, one only needsto know where the zoom started (x, y) and the underlying axes (a).
The index (i) and view (a._get_view()) are unused, so just remove
them.
PR Summary
PR Checklist