Backport PR #16770 on branch v3.2.x (Fix tuple markers) #16791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
To get this to work, it looks like we should either increase the tolerance on |
|
I vote backport, it is testing details, not user-facing so it is OK. xref #16795 |
|
Thanks for this fix! Broken marker tuples are currently impacting my packages, is there a timeline when 3.2.1 will be on pypi? In the meantime I guess I'll pin my versions to 3.1.2 |
|
Well, it's good to see someone uses it, and fixing it by chance was useful. Please consider adding 3.2.1 is planned for tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #16770: Fix tuple markers