Skip to content

Make the Qt interactive zoom rectangle black & white. #16798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2020
Merged

Make the Qt interactive zoom rectangle black & white. #16798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions doc/users/next_whats_new/2020-03-16-qtzoom.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Qt zoom rectangle now black and white
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This makes it visible even over a dark background.
11 changes: 8 additions & 3 deletions lib/matplotlib/backends/backend_qt5.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,10 +479,15 @@ def drawRectangle(self, rect):
# to be called at the end of paintEvent.
if rect is not None:
def _draw_rect_callback(painter):
pen = QtGui.QPen(QtCore.Qt.black, 1 / self._dpi_ratio,
QtCore.Qt.DotLine)
scaled_rect = [pt / self._dpi_ratio for pt in rect]
pen = QtGui.QPen(QtCore.Qt.black, 1 / self._dpi_ratio)
pen.setDashPattern([3, 3])
painter.setPen(pen)
painter.drawRect(*(pt / self._dpi_ratio for pt in rect))
painter.drawRect(*scaled_rect)
pen.setDashOffset(3)
pen.setColor(QtCore.Qt.white)
painter.setPen(pen)
painter.drawRect(*scaled_rect)
else:
def _draw_rect_callback(painter):
return
Expand Down