Skip to content

Don't forget to export isdeleted on Qt4. #16835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2020
Merged

Don't forget to export isdeleted on Qt4. #16835

merged 1 commit into from
Mar 19, 2020
+1 −1

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 19, 2020

PR Summary

Closes #16834, I think (I don't actually have a qt4 install to check :-)).

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. GUI: Qt labels Mar 19, 2020
@anntzer anntzer added this to the v3.2.2 milestone Mar 19, 2020
@tacaswell
Copy link
Member

Thanks! I was about to open a PR with the same fix but you beat me by ~40 minutes.

@timhoffm timhoffm merged commit fd2e276 into matplotlib:master Mar 19, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 19, 2020
@timhoffm @meeseeksmachine
Backport PR matplotlib#16835: Don't forget to export isdeleted on Qt4.
6e86ff8
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 19, 2020
Merged
@anntzer anntzer deleted the isdeleted branch March 19, 2020 17:19
timhoffm added a commit that referenced this pull request Mar 19, 2020
@timhoffm
Merge pull request #16842 from meeseeksmachine/auto-backport-of-pr-16…
a1eb4e5 
…835-on-v3.2.x

Backport PR #16835 on branch v3.2.x (Don't forget to export isdeleted on Qt4.)
@tacaswell tacaswell mentioned this pull request Jun 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
GUI: Qt Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging this pull request may close these issues.

Error importing FigureCanvas
3 participants
@anntzer @tacaswell @timhoffm