Skip to content

Inline some more kwargs into setup.py's setup() call. #16838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2020
Merged

Inline some more kwargs into setup.py's setup() call. #16838

merged 1 commit into from
Mar 19, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 19, 2020

  • long_description can be defined right where it's used.
  • It seems nicer to also define classifiers at the point of use
    (together with other "metadata"-like entries) rather than at the top
    of the file, far away from the point of use.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Inline some more kwargs into setup.py's setup() call.
e83034a 
- long_description can be defined right where it's used.
- It seems nicer to also define classifiers at the point of use
  (together with other "metadata"-like entries) rather than at the top
  of the file, far away from the point of use.
@anntzer anntzer added this to the v3.3.0 milestone Mar 19, 2020
@QuLogic QuLogic merged commit 7127304 into matplotlib:master Mar 19, 2020
@anntzer anntzer deleted the setuppykwargs branch March 19, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Build Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm