Skip to content

Ticks are not markers #16847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2020
Merged

Ticks are not markers #16847

merged 3 commits into from
Apr 24, 2020

Conversation

igordertigor
Copy link

@igordertigor igordertigor commented Mar 19, 2020 •
edited
Loading

Setting markeredgecolor in rcParams should not affect color of ticks

When setting the lines.markeredgecolor in the rcParams, this changes the color of tickmarkers as well, while xtick.color and ytick.color leave the color of tickmarkers unaffected. This is unintuitive. This pull request should fix that.

PR Checklist

  • [x ] Has Pytest style unit tests
  • [x ] Code is Flake 8 compliant
  • New features are documented, with examples if plot related: No new features.
  • Documentation is sphinx and numpydoc compliant: No documentation
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there): No major new feature
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way: Backward compatible.

@efiring efiring added this to the v3.3.0 milestone Mar 23, 2020
QuLogic
QuLogic reviewed Apr 23, 2020
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Actions are broken so there's no flake8 check, but I think there's at least one thing.

Please also rebase so that the test images are removed entirely.

@QuLogic QuLogic merged commit 45e1ca9 into matplotlib:master Apr 24, 2020
@QuLogic
Copy link
Member

QuLogic commented Apr 24, 2020

Thanks @igordertigor!

This was referenced Apr 24, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
API: consistency topic: ticks axis labels
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@igordertigor @QuLogic @tacaswell @efiring