Skip to content

BLD: Auto-trigger macOS/Linux wheels on tags. #16867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Mar 21, 2020

PR Summary

I tested on my fork by pushing a bogus tag, which worked except the push, so I also added an if so it doesn't run on people's forks, which skips running it. This took way too long for me to figure out.

We'll need to set the deploy key secret on this repo for this to work.

PR Checklist

  • [n/a] Has Pytest style unit tests
  • [n/a] Code is Flake 8 compliant
  • [n/a] New features are documented, with examples if plot related
  • [n/a] Documentation is sphinx and numpydoc compliant
  • [n/a] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [n/a] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic QuLogic added the Build label Mar 21, 2020
@QuLogic QuLogic added this to the v3.2.2 milestone Mar 21, 2020
@QuLogic
Copy link
Member Author

QuLogic commented Mar 21, 2020

I tried to set the deploy key using the API, but it gave a weird response (though not strictly an error), so I'm not sure it got set.

@QuLogic QuLogic mentioned this pull request Mar 21, 2020
1 task
@QuLogic QuLogic requested a review from tacaswell March 21, 2020 23:56
@tacaswell tacaswell merged commit f28c929 into matplotlib:master Mar 22, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 22, 2020
@QuLogic QuLogic deleted the auto-wheel branch March 22, 2020 03:15
timhoffm added a commit that referenced this pull request Mar 22, 2020
…867-on-v3.2.x

Backport PR #16867 on branch v3.2.x (BLD: Auto-trigger macOS/Linux wheels on tags.)
@QuLogic
Copy link
Member Author

QuLogic commented Mar 23, 2020

Can you check that the deploy key is added to the Actions secrets?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants