Skip to content

Cleanup new_fixed_axis examples. #16877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Cleanup new_fixed_axis examples. #16877

merged 1 commit into from
Mar 26, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 22, 2020

  • We can call new_fixed_axis directly on the axes instance, which will
    forward the call to the grid_helper and also correctly set the axes
    kwarg.
  • In demo_parasite_axes and demo_parasite_axes2, group together the
    limits and labels settings, and remove some duplicates.
  • Reword the description of demo_parasite_axes2.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

multiple different values onto one single plot. Notice how in this example,
*par1* and *par2* are both obtained by calling twinx, meaning both are
tied directly to the x-axis. From there, each of those two axis can behave
separately from the each other, meaning they can take on separate values from
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
separately from the each other, meaning they can take on separate values from
separately from each other, meaning they can take on separate values from

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up rewriting the whole paragraph.

- We can call new_fixed_axis directly on the axes instance, which will
  forward the call to the grid_helper and also correctly set the *axes*
  kwarg.
- In demo_parasite_axes and demo_parasite_axes2, group together the
  limits and labels settings, and remove some duplicates.
- Reword the description of demo_parasite_axes2.
@QuLogic QuLogic merged commit 536fffe into matplotlib:master Mar 26, 2020
@anntzer anntzer deleted the nfa branch March 26, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants