Skip to content

Path center of mass #16889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Path center of mass #16889

wants to merge 4 commits into from

Conversation

brunobeltran
Copy link
Contributor

@brunobeltran brunobeltran commented Mar 23, 2020 •
edited
Loading

PR Summary

We should allow users to center markers by center of mass. This is the code to compute the center of mass of an arbitrary path (treats paths of different intrinsic dimension correctly).

Roadmap:

#16812 (*) <- #16832 (*) <- #16859 (*) <- #16888 (*) <- (This PR) (*) <- #16891 (MarkerStyle improvements!)

"<-" means "depends on", and "(*)" marks PRs whose implementations are complete and fully ready for review.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

This was referenced Mar 23, 2020
Draft
Open
Open
Merged
Merged
@brunobeltran brunobeltran force-pushed the path_center_of_mass branch 7 times, most recently from 82b1359 to 348e7e1 Compare March 31, 2020 02:03
@brunobeltran brunobeltran force-pushed the path_center_of_mass branch from 348e7e1 to cb37c8f Compare April 9, 2020 21:28
@jklymak jklymak marked this pull request as draft July 23, 2020 03:18
@github-actions
Copy link

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.

@github-actions github-actions bot added the status: inactive Marked by the “Stale” Github Action label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: inactive Marked by the “Stale” Github Action status: needs rebase status: waiting for other PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunobeltran @QuLogic