Turn fontdict & minor into kwonly parameters for set_{x,y}ticklabels. #16904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with the general trend of making "minor" a kwonly
param, and will help in making set_{x,y}ticklabels just a thin wrapper
around Axis.set_ticklabels.
QuLogic
reviewed
Mar 25, 2020
| @@ -3422,6 +3422,7 @@ def get_xticklabels(self, minor=False, which=None): | |||
| """ | |||
| return self.xaxis.get_ticklabels(minor=minor, which=which) | |||
|
|
|||
| @cbook._make_keyword_only("3.3", "fontdict") | |||
There was a problem hiding this comment.
But you didn't mark minor, does this propagate to the remaining parameters?
There was a problem hiding this comment.
Yes. (The only way to pass minor positionally would be to also pass fontdict positionally.)
timhoffm
approved these changes
Mar 25, 2020
QuLogic
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with the general trend of making "minor" a kwonly
param, and will help in making set_{x,y}ticklabels just a thin wrapper
around Axis.set_ticklabels (#16903).
PR Summary
PR Checklist