update FAQ on how to register pandas converters #16906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
story645
approved these changes
Mar 25, 2020
There was a problem hiding this comment.
Thanks for the PR & it's fine as is. This is my suggestion but I didn't want to overstep by directly committing the changes:
If you prefer the pandas converters and locators, you can register them.
This is done automatically when calling a pandas plot function and may be unnecessary
when using pandas instead of matplotlib directly. ::
`pandas.tseries.converter` no longer exists, and the individual converters are not part of the public API so this change updates the documentation to reflect how to properly register the pandas converters with matplotlib.
98aa4b7 to
a6b42cb
Compare
|
Done |
QuLogic
approved these changes
Mar 26, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 27, 2020
QuLogic
added a commit
that referenced
this pull request
Mar 27, 2020
…906-on-v3.2.1-doc Backport PR #16906 on branch v3.2.1-doc (update FAQ on how to register pandas converters)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
pandas.tseries.converterno longer exists, and the individual converters are not part of the public API so this change updates the documentation to reflect how to properly register the pandas converters with matplotlib.PR Checklist