Skip to content

Avoid changing dpi in Text.get_window_extent if unspecified. #16927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Avoid changing dpi in Text.get_window_extent if unspecified. #16927

wants to merge 1 commit into from

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Mar 27, 2020 •
edited
Loading

PR Summary

Somehow this causes height changes to propagate from the canvas until it's zero-height (for Tk at least). This is probably a bug, but it's much more subtle and difficult to find, so this patch will suffice for now.

See #16926, which this fixes, but not entirely satisfactorily. Maybe if we're lucky, it'll fix the flakiness on AppVeyor too.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [n/a] New features are documented, with examples if plot related
  • [n/a] Documentation is sphinx and numpydoc compliant
  • [n/a] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [n/a] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic QuLogic added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: text labels Mar 27, 2020
@QuLogic QuLogic added this to the v3.3.0 milestone Mar 27, 2020
@QuLogic
Avoid changing dpi in Text.get_window_extent if unspecified.
d1f183a 
Somehow this causes height changes to propagate from the canvas until
it's zero-height (for Tk at least). This is probably a bug, but it's
much more subtle and difficult to find, so this patch will suffice for
now.
@jklymak jklymak requested a review from anntzer March 27, 2020 04:12
@QuLogic
Copy link
Member Author

QuLogic commented Mar 27, 2020

Closing in favour of #16929, which I believe to be the more correct fix.

@QuLogic QuLogic closed this Mar 27, 2020
@QuLogic QuLogic deleted the text-dpi branch March 27, 2020 06:40
@anntzer anntzer removed their request for review March 27, 2020 09:55
@tacaswell tacaswell removed the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Mar 30, 2020
@tacaswell tacaswell removed this from the v3.3.0 milestone Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: text
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuLogic @tacaswell