Cleanup and avoid refleaks OSX Timer__timer_start. #16942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference leaks where occurring with early `return NULL`, e.g. if `PyObject_IsTrue(attribute)` or `PyMethod_Check(attribute)` failed. Also there's plenty of cases where one doesn't need to set the error message, as PyObject_GetAttrString (for example) will set the correct exception. Also apply similar cleanups to drawRect, even though it doesn't actually suffer from refleaks.
tacaswell
approved these changes
Mar 28, 2020
dopplershift
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference leaks where occurring with early
return NULL, e.g. ifPyObject_IsTrue(attribute)orPyMethod_Check(attribute)failed.Also there's plenty of cases where one doesn't need to set the error
message, as PyObject_GetAttrString (for example) will set the correct
exception.
Also apply similar cleanups to drawRect, even though it doesn't actually
suffer from refleaks.
PR Summary
PR Checklist