Skip to content

TST: Don't modify actual pyplot file for boilerplate test. #16949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2020
Merged

TST: Don't modify actual pyplot file for boilerplate test. #16949

merged 1 commit into from
Mar 29, 2020
+29 −25

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Mar 29, 2020

PR Summary

This should prevent git/versioneer from thinking the working tree is dirty if some parallel test happens to run while this one is mid-write.

Maybe will help to fix up #16941.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [n/a] New features are documented, with examples if plot related
  • [n/a] Documentation is sphinx and numpydoc compliant
  • [n/a] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [n/a] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic
TST: Don't modify actual pyplot file for boilerplate test.
f4d42f7 
This should prevent git/versioneer from thinking the working tree is
dirty if some parallel test happens to run while this one is mid-write.
@QuLogic QuLogic mentioned this pull request Mar 29, 2020
Closed
@timhoffm timhoffm added this to the v3.2.2 milestone Mar 29, 2020
@timhoffm timhoffm merged commit 0bf4f55 into matplotlib:master Mar 29, 2020
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 29, 2020
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 29, 2020
@timhoffm @meeseeksmachine
Backport PR matplotlib#16949: TST: Don't modify actual pyplot file fo…
ffa1669 
…r boilerplate test.
@QuLogic QuLogic deleted the pyplot-test-not-dirty branch March 29, 2020 02:33
timhoffm added a commit that referenced this pull request Mar 29, 2020
@timhoffm
Merge pull request #16950 from meeseeksmachine/auto-backport-of-pr-16…
0c6c184 
…949-on-v3.2.x

Backport PR #16949 on branch v3.2.x (TST: Don't modify actual pyplot file for boilerplate test.)
@anntzer anntzer mentioned this pull request Apr 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @tacaswell @timhoffm