Simplify animation writer fallback. #16967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
approved these changes
Mar 30, 2020
|
#16966 should be merged first and backported and then this one. |
|
We don't have a hard dependency on pillow with 3.2 so we should not backport this to 3.2.x |
|
Ah, lost track of when the dependency came in. |
|
Flake8: ./lib/matplotlib/animation.py:1095:50: F821 undefined name 'alt_writer' |
a434962 to
e079830
Compare
|
oops |
The fallback now always returns PillowWriter, which is the first registered writer and is always available, so we may just as well be more explicit. (Not all writers support all output formats, but we don't have machinery to select writers based on the output format right now anyways.)
e079830 to
4bbca88
Compare
|
rebased |
QuLogic
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fallback now always returns PillowWriter, which is the first
registered writer and is always available, so we may just as well be
more explicit.
(Not all writers support all output formats, but we don't have machinery
to select writers based on the output format right now anyways.)
Slightly more complex than #16966 so I'm milestoning this one to 3.3.0 instead, but we could also backport it to 3.2.
PR Summary
PR Checklist