Skip to content

Correctly disable more drawing methods in tight_bboxing renderer. #16980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2020
Merged

Correctly disable more drawing methods in tight_bboxing renderer. #16980

merged 1 commit into from
Mar 31, 2020
+9 −2

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 31, 2020

These methods also try to write to the output file.

Closes #16978.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. backend: svg labels Mar 31, 2020
@anntzer anntzer added this to the v3.3.0 milestone Mar 31, 2020
@tacaswell
Copy link
Member

Can you add a test for the svgz case? I think a trivial figure will hit this?

tacaswell
tacaswell approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would prefer a test to make sure we don't lose this code in the future.

@anntzer
Correctly disable more drawing methods in tight_bboxing renderer.
001afaf 
These methods also try to write to the output file.
@anntzer
Copy link
Contributor Author

anntzer commented Mar 31, 2020

sure, test added.

@QuLogic QuLogic merged commit c30129b into matplotlib:master Mar 31, 2020
@QuLogic
Copy link
Member

QuLogic commented Mar 31, 2020

Wait, did you want this backported? Or a different fix for 3.2.2?

@anntzer anntzer deleted the draw_disabled branch March 31, 2020 20:34
@anntzer
Copy link
Contributor Author

anntzer commented Mar 31, 2020 •
edited
Loading

Oops, I guess this should have been milestone to 3.2.2, sorry.
Tagged, but dunno if meeseeksdev can handle that.

@QuLogic
Copy link
Member

QuLogic commented Mar 31, 2020

@meeseeksdev backport to v3.2.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 31, 2020
@QuLogic @meeseeksmachine
Backport PR matplotlib#16980: Correctly disable more drawing methods …
c341652 
…in tight_bboxing renderer.
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 31, 2020
Merged
@QuLogic QuLogic modified the milestones: v3.3.0, v3.2.2 Mar 31, 2020
QuLogic added a commit that referenced this pull request Apr 1, 2020
@QuLogic
Merge pull request #16989 from meeseeksmachine/auto-backport-of-pr-16…
8ac76de 
…980-on-v3.2.x

Backport PR #16980 on branch v3.2.x (Correctly disable more drawing methods in tight_bboxing renderer.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
backend: svg Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging this pull request may close these issues.

savefig("myplot.svgz", bbox_inches="tight") fails
3 participants
@anntzer @tacaswell @QuLogic