Fixing OSX makefile #17
Conversation
…les from build process.
Although a hard-coded PYVERSION=2.6 is safe for snow leopard, it might make more sense to leave it blank, defaulting to the 'python' command that takes precedence in the PATH. Also, suggesting in the documentation that it can be included in the command line might prompt users to choose the right version without having to edit the makefile.
| @@ -9,5 +9,5 @@ lib, png or freetype on your system | |||
|
|
|||
| Example usage:: | |||
|
|
|||
| PREFIX=/Users/jdhunter/dev make -f make.osx fetch deps mpl_install | |||
| PREFIX=/Users/jdhunter/dev [PYVERSION=2.6] make -f make.osx fetch deps mpl_install | |||
There was a problem hiding this comment.
The brackets that mean optional settings could be mistaken for syntax. I suggest reformulating this along these lines (note that you can set variables on the make command line):
make -f make.osx fetch deps mpl_install PREFIX=/Users/jdhunter/dev PYVERSION=2.6
Variables:
PREFIX (required): where to install the dependencies
PYVERSION (optional): <<<please describe the effect and the default>>>
The Python libraries will be installed in the usual location, not under PREFIX.
There was a problem hiding this comment.
Thanks for the tip. I was just following standard man notation, but I understand your concern and added a couple commits to address this.
|
I would still like to get a comment from John Hunter on removing the --prefix argument. |
|
Summary of changes in my commit:
I got "make binaries" almost working by disabling wxagg from the setup.cfg file and fudging some version numbers of the generated files. I don't think this review request broke anything there, it's just that my system doesn't have a good version of wxPython. |
|
This won't merge cleanly to master. I'll prepare another pull request for that. |
|
In the absence of further comments, I'll merge this in. |
DOC: explain changes to boxplot styles
fixing log10 in Dr_db and moving pyplot import into method
I updated a couple of links for fetch and added some stray files to clean. I'm also making a couple of suggestions regarding requiring PYVERSION in the command line and dropping the PREFIX from mpl_install. For this last one, I'm assuming that the dependencies are compile-time and matplotlib will work correctly from the relevant site-packages (I haven't seen any problems yet, although I've kept the dependencies in the PREFIX), but I welcome any comments or corrections.