Skip to content

ci: Publish result images as Azure artifacts. #17011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Apr 2, 2020

This should allow us to debug result images if they're failing on Azure.

@QuLogic
Copy link
Member Author

QuLogic commented Apr 3, 2020

I'm thinking we probably want to add a condition so publishing works when stuff fails, but I didn't add it here just to see what the results look like. Should we publish always or only on failure?

@anntzer
Copy link
Contributor

anntzer commented Apr 3, 2020

I guess only-on-failure is good enough for now?

@QuLogic
Copy link
Member Author

QuLogic commented Apr 3, 2020

Hmm, looks like I need to give it a stage-specific name.

@QuLogic
Copy link
Member Author

QuLogic commented Apr 3, 2020

So Windows Prerelease build failed because nothing was actually run. Seems we're a bit too relaxed with that one.

@QuLogic
Copy link
Member Author

QuLogic commented Apr 3, 2020

I added the on-failure condition, and skipped artifacts for the Prerelease build (which is broken right now). You can see what it looks like in the previous build. In the top card, under the Related heading, there is the "9 published" link which points to the artifacts. If you're on a specific Job view, then there's a link to "1 artifact produced".

Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

@tacaswell tacaswell merged commit 285e987 into matplotlib:master Apr 5, 2020
@tacaswell tacaswell added this to the v3.3.0 milestone Apr 5, 2020
@QuLogic QuLogic deleted the azure-artifacts branch April 6, 2020 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants