Add eslint & prettier, and re-format JS #17026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are setup similar to ipywidgets, but with slightly less newer things, as our JavaScript parts are much older.
tacaswell
approved these changes
Apr 4, 2020
|
I'll leave it for about a week, but then will merge as there's a whole train of PRs that follow. |
timhoffm
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This re-formats the JavaScript code we have using prettier, and adds eslint. The config is similar to ipywidgets, though without the TypeScript bits. It is a corollary to matplotlib/ipympl#213 so that we can sync changes better without stylistic drift (if necessary.) Some things in that PR are not applied here because we do not use any of the newer JS features.
PR Checklist