Fix missing-references.json. #17045
Merged
Fix missing-references.json. #17045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think what happened is that the way nested classes are referred to in inheritance diagrams has improved (the qualified name is more correct now), which caused missing-references.json to go out of sync. Unfortunately this means missing-references.json can either be compatible with sphinx<3.0 or with sphinx>3.0, but to be compatible with both we'd likely need to generate one with both versions and merge the two json files, which seems not worth it. Instead, just drop nitpicky mode for older sphixes (sphinges?).
tacaswell
approved these changes
Apr 6, 2020
timhoffm
approved these changes
Apr 6, 2020
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
|
Working on backporting this, just going to re-generate the json file on the 3.2.x branch. |
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Apr 6, 2020
Merge pull request matplotlib#17045 from anntzer/docrefs Fix missing-references.json. Conflicts: doc/missing-references.json - fixed by fully regenerating
timhoffm
added a commit
that referenced
this pull request
Apr 7, 2020
…-v3.2.x Backport PR #17045: Fix missing-references.json.
tacaswell
pushed a commit
to SidharthBansal/matplotlib
that referenced
this pull request
Apr 8, 2020
Fix missing-references.json.
Conflicts:
doc/missing-references.json
- re-generated the skip list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think what happened is that the way nested classes are referred to in
inheritance diagrams has improved (the qualified name is more correct
now), which caused missing-references.json to go out of sync.
Unfortunately this means missing-references.json can either be
compatible with sphinx<3.0 or with sphinx>3.0, but to be compatible with
both we'd likely need to generate one with both versions and merge the
two json files, which seems not worth it. Instead, just drop nitpicky
mode for older sphixes (sphinges?).
PR Summary
PR Checklist