Skip to content

Cleanup multi_image example. #17072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2020
Merged

Cleanup multi_image example. #17072

merged 1 commit into from
Apr 8, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 8, 2020

The example has some issues pointed out elsewhere (#17052), but we can make it
less a pain to investigate with small cleanups:

  • Don't use a weird/nonstandard colormap.
  • Don't scale the data to 1e-6 (which makes editing the values via the
    Qt figure options slightly a pain).

(This doesn't fix the underlying issues, though.)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Cleanup multi_image example.
1c61e5a 
The example has some issues pointed out elsewhere, but we can make it
less a pain to investigate with small cleanups:

- Don't use a weird/nonstandard colormap.
- Don't scale the data to 1e-6 (which makes editing the values via the
  Qt figure options slightly a pain).
@anntzer anntzer added this to the v3.3.0 milestone Apr 8, 2020
tacaswell
tacaswell approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyone can merge on CI green.

@anntzer anntzer merged commit 66d675a into matplotlib:master Apr 8, 2020
@anntzer anntzer deleted the multim branch April 8, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anntzer @tacaswell