Skip to content

Fix SyntaxErrors when running setup in old Python #17076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2020
Merged

Fix SyntaxErrors when running setup in old Python #17076

merged 2 commits into from
Apr 9, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Apr 8, 2020

PR Summary

We just got another report about this, so that tells me we're not ready to remove the Python version check in setup.py. I know the suggestion in #16837 is to move the jQuery stuff, but soon I'll be removing it entirely, so I didn't bother.

Fixes #17075.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

QuLogic added 2 commits April 8, 2020 17:11
@QuLogic
Remove new Python syntax from setup.py.
13ee932 
We cannot yet rely on pip to be new enough to recognize out
python_requires, and we get several reports of broken syntax on older
Python.
@QuLogic
Add current Python version in setup.py error message.
dabc706
@QuLogic QuLogic added the Build label Apr 8, 2020
@QuLogic QuLogic added this to the v3.2.2 milestone Apr 8, 2020
@timhoffm timhoffm merged commit 2c62f06 into matplotlib:master Apr 9, 2020
@lumberbot-app
Copy link

lumberbot-app bot commented Apr 9, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 2c62f063e8bf1a1109cd9e78c472ac026c73b074
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #17076: Fix SyntaxErrors when running setup in old Python'
  1. Push to a named branch :
git push YOURFORK v3.2.x:auto-backport-of-pr-17076-on-v3.2.x
  1. Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR #17076 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@QuLogic QuLogic deleted the old-setup branch April 9, 2020 07:54
timhoffm added a commit to timhoffm/matplotlib that referenced this pull request Apr 18, 2020
@timhoffm
Backport PR matplotlib#17076: Fix SyntaxErrors when running setup in …
5f3204f 
…old Python
@timhoffm timhoffm mentioned this pull request Apr 18, 2020
Merged
dstansby added a commit that referenced this pull request Apr 18, 2020
@dstansby
Merge pull request #17187 from timhoffm/auto-backport-of-pr-17076-on-…
964372c 
…v3.2.x

Backport PR #17076: Fix SyntaxErrors when running setup in old Python
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging this pull request may close these issues.

Installation error downloading jquery on python3 on Ubuntu
3 participants
@QuLogic @tacaswell @timhoffm