Skip to content

Cleanup some imports in tests #17089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2020
Merged

Cleanup some imports in tests #17089

merged 3 commits into from
Apr 17, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Apr 10, 2020

PR Summary

I noticed some cases where imports were using a different name, or double-imported in one file, so clean that up a bit.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

timhoffm
timhoffm reviewed Apr 10, 2020
View reviewed changes
@tacaswell tacaswell added this to the v3.3.0 milestone Apr 10, 2020
tacaswell
tacaswell approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly agree with both of @timhoffm 's comments and this should not be merged until @QuLogic responds to them but am 👍 on this independent of if they get addressed.

@QuLogic QuLogic force-pushed the test-import branch 3 times, most recently from ef7b7be to 5d0d50d Compare April 16, 2020 02:10
timhoffm
timhoffm approved these changes Apr 17, 2020
View reviewed changes
@anntzer anntzer merged commit eecb9cc into matplotlib:master Apr 17, 2020
@QuLogic QuLogic deleted the test-import branch April 17, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@tacaswell tacaswell tacaswell approved these changes

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@QuLogic @tacaswell @anntzer @timhoffm