Feature: add edit_parameters widget to toolbar for GUI backends #17105
Conversation
crvapply implemented, an idea for crvcancel and crvconfirm
fixed minor bug
in apply labels are shown correctly
added function headers, parameter explanation and attributes
crvapply implemented, an idea for crvcancel and crvconfirm
fixed minor bug
in apply labels are shown correctly
added function headers, parameter explanation and attributes
| self.toolfig = toolfig | ||
| self.toolfig.subplots_adjust(left=0.2, right=0.85) | ||
| axes = self.targetfig.get_axes() | ||
| self.ax, = axes |
There was a problem hiding this comment.
This fails if there are multiple subplots (Qt currently uses a first combobox to select the axes to edit, in that case).
|
This will likely take a bit of time to fully review, but in general it looks nice 👍 |
|
Also note that I took over a few of your improvements to TextBox (thanks!) and generalized them in #17108, so you'll need to remove them here. |
|
Ooops, OK, the related issue makes it more clear - this adds this feature to more backends, not just qt. That makes more sense to me. Still this needs a rebase, and someone to commit to helping see it through. |
|
Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it. |
|
This was clearly a lot of work and seems worthwhile (until we manage to get a native version of the parameters editor for all toolkits, which is not something likely to happen quickly). |
PR Summary
Added feature for editing parameters in NavigationBar.
Created a new widget called AxesTool.
Works with backends: gtk3, wx, and tk.
Closes #13195
PR Checklist