-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
BUG: Fix formatting error in GridSpec.__repr__ #17131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix formatting error in GridSpec.__repr__ #17131
Conversation
Fix this error in `GridSpec.__repr__` when formatting the `width_ratios` or `height_ratios` arguments: TypeError: not all arguments converted during string formatting
Thanks! What input reproduces this? It would be good to get a test so it does not come back. |
Looks like you just need to specify one of the args, i.e., in a REPL:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... or we can just fstringify this and the trap won't exist anymore...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be merged postci
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Looks like this never worked with the ratios back to when it came in for 3.0. |
…v3.2.x Backport PR #17131 on branch v3.2.x
Fix this error in
GridSpec.__repr__
when formatting thewidth_ratios
orheight_ratios
arguments: