Skip to content

BUGFIX: conditional for add_axes arg deprecation #17142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2020
Merged

BUGFIX: conditional for add_axes arg deprecation #17142

merged 1 commit into from
Apr 15, 2020

Conversation

brunobeltran
Copy link
Contributor

PR Summary

Fixes #17114.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@timhoffm
Copy link
Member

Flake8:
./lib/matplotlib/figure.py:1207:30: E713 test for membership should be 'not in'

@brunobeltran brunobeltran force-pushed the add_axes-kwargs-bugfix branch from 29e564d to dd7259f Compare April 15, 2020 07:39
@brunobeltran
Copy link
Contributor Author

Thanks @timhoffm, hopefully CI passes this time.

Pretty embarrassing that I managed to fail flake8 with like a four-word change, didn't even bother running it the first time locally 😅

anntzer
anntzer approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyone can merge postci

@anntzer anntzer merged commit 291d5d7 into matplotlib:master Apr 15, 2020
@QuLogic QuLogic added this to the v3.3.0 milestone Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

add_axes shows deprecation warning when called with only kwargs
4 participants
@brunobeltran @timhoffm @anntzer @QuLogic