Skip to content

Deprecate text.latex.preview rcParam. #17156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2020
Merged

Deprecate text.latex.preview rcParam. #17156

merged 1 commit into from
Apr 30, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 16, 2020

It is now unneeded; see changelog note.

Followup to #16476.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Deprecate text.latex.preview rcParam.
96d7d05 
It is now unneeded; see changelog note.
@anntzer anntzer added this to the v3.3.0 milestone Apr 16, 2020
@QuLogic
Copy link
Member

QuLogic commented Apr 18, 2020

Speaking of #16476, that updated test with the tolerance is now even worse for me, with RMS of 12.877.
test_usetex

@anntzer
Copy link
Contributor Author

anntzer commented Apr 18, 2020

Are you using dvipng 1.16? For any other version of dvipng I disable freetype with -freetype0 and things should match exactly, but dvipng 1.16 has a bug that prevents that and it's basically expected that the test fails with it. I probably could xfail in that case...

@QuLogic
Copy link
Member

QuLogic commented Apr 18, 2020

No, seems to be 1.15:

This is dvipng (dvipng (TeX Live)) 1.15 Copyright 2002-2015 Jan-Ake Larsson

@anntzer
Copy link
Contributor Author

anntzer commented Apr 18, 2020

At least locally things pass for me with dvipng 1.15, so I don't have an idea right now...

@QuLogic QuLogic merged commit 0652132 into matplotlib:master Apr 30, 2020
@anntzer anntzer deleted the unpreview branch April 30, 2020 19:32
@QuLogic QuLogic mentioned this pull request Mar 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
topic: rcparams topic: text/usetex
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @jklymak