Skip to content

Correctly go through property setter when init'ing Timer interval. #17160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2020
Merged

Correctly go through property setter when init'ing Timer interval. #17160

merged 1 commit into from
Apr 17, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 16, 2020

The setter casts the interval to an int, which is required at least by
the tk backend.

Closes #17149 (comment).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Apr 16, 2020
@QuLogic
Copy link
Member

QuLogic commented Apr 17, 2020

This appears to be broken on some backends.

@anntzer
Copy link
Contributor Author

anntzer commented Apr 17, 2020

Hopefully fixed, and caught a bug on timerwx at the same time (see changelog).

@anntzer
Correctly go through property setter when init'ing Timer interval.
96690e1 
The setter casts the interval to an int, which is required at least by
the tk backend.

This caught a bug in the wx timer, where just setting the interval would
start the timer.  Fixed that.
@QuLogic QuLogic merged commit 7b14917 into matplotlib:master Apr 17, 2020
@jklymak jklymak mentioned this pull request Apr 17, 2020
Closed
@anntzer anntzer deleted the timerintinterval branch April 18, 2020 08:11
@QuLogic QuLogic mentioned this pull request Oct 2, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
GUI: tk topic: animation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

Rasterization creates multiple bitmap elements and large file sizes
3 participants
@anntzer @QuLogic @timhoffm